Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove invalid imagePushSecret from BuildConfig when using internal registry #35695

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

iocanel
Copy link
Contributor

@iocanel iocanel commented Sep 2, 2023

Resolves: #35647

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 2, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@geoand geoand merged commit 68af440 into quarkusio:main Sep 4, 2023
@quarkus-bot quarkus-bot bot added this to the 3.4 - main milestone Sep 4, 2023
@danieloh30
Copy link

@geoand This fix seems to have been added to the 3.4.0 or later version.

  1. When will 3.4.0 be released (roughly)?
  2. Any workaround to avoid this issue until the fix is added?

@geoand
Copy link
Contributor

geoand commented Sep 4, 2023

@danieloh30 this will be backported to the next 3.3 release as well as being part of 3.4.0.CR1

@danieloh30
Copy link

sounds cool! thx for a quick answer @geoand

@geoand
Copy link
Contributor

geoand commented Sep 4, 2023

🙏🏼

@gsmet gsmet modified the milestones: 3.4 - main, 3.3.2 Sep 4, 2023
@iocanel
Copy link
Contributor Author

iocanel commented Sep 5, 2023

@danieloh30: a workaround would be to create an empty image push secret. Haven't tried it, but it should possibly work.

@iocanel
Copy link
Contributor Author

iocanel commented Sep 5, 2023

An alternative workaround I tried is to remove the registry completely, set an empty image group (so that the image is a single segment image) and rely on the fact that the ImageStreams use local lookup policy.

While this works ok for Deployment it does not seem to work for Knative Service. It's not clear to me why.
Feedback from Openshift or Knative people would possibly help. @maxandersen @rhuss?

@danieloh30
Copy link

That's really helpful and good to know!

@rhuss
Copy link

rhuss commented Sep 5, 2023

While not being able to fully dive into this issue, I can nevertheless that
Knative does not work well with ImageStream because a KService is not an intrinsic OpenShift object that the build controller is aware of. E.g. there can be no redeployment triggered after a new build: https://issues.redhat.com/browse/BUILD-100

Not sure if this helpful in this context though :-)

@danieloh30
Copy link

Good to know @rhuss I'd better wait for the next release for this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Knative deployment is broken using OpenShift extension in v3.3.0 and v.3.3.1
5 participants